ETQ admin: corrige le nouveau bouton de publication d'une démarche #10707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara22
approved these changes
Aug 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10707 +/- ##
==========================================
+ Coverage 80.28% 80.29% +0.01%
==========================================
Files 1253 1253
Lines 26623 26623
Branches 4775 4775
==========================================
+ Hits 21373 21376 +3
+ Misses 5250 5247 -3 ☔ View full report in Codecov by Sentry. |
colinux
force-pushed
the
fix-unpublished-changes-button
branch
from
3ebef07 to
eccfde8
Compare
Merged
via the queue into
demarches-simplifiees:main
with commit Aug 21, 2024
3796210
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ça doit être un PUT et pas un POST.
Gère aussi le cas du button disable, même logique que le callout sur le show. Particularité: le cas normal doit être un link et pas un button, car le button en PUT génère un form qui fait sauter le layout ici. Mais quand ça doit être disabled, ça ne peut pas être un link
J'en ai profité pour renommer navbar => sticky header